Stable sorting and icons for connect screen #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses items jumping up and down in the connect screen when devices appear/disappear for example on LAN. It also adds different icons depending on the connection type. To avoid flickering, the model is only updated if it is changed. I also took the opportunity to fix the binding loop errors in this qml, as well as cleaning up some of the javascript code for model building.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses items jumping up and down in the connect screen when
devices appear/disappear for example on LAN, as well as making the devices
appear in a more predictable order.
It also adds different icons depending on the connection type.
To avoid flickering, the model is only updated if it is changed.
I also took the opportunity to fix the binding loop errors in this qml,
as well as cleaning up some of the javascript code for model building.