Update emotiv.py #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Threw NotImplementedError for get_channels and get_sampling_frequency. Also the vendor ID and product ID are for the developer model.
Increased timeout (was too short for raspberry pi) Data returned was in the wrong format, fixed need more than one value to unpack error.
Fixed typos, type errors, misunderstanding how get_channels worked and what it expected, and added the option to check for other product id and vendor id (for what I think is either the researcher/developer or consumer models of the headset)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threw NotImplementedError for get_channels and get_sampling_frequency. Also the vendor ID and product ID are for the developer model.