Add Info operations family and start with GetColumnType #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Other Operations" family of functions in the ROOT RDataFrame class has been added to PyRDF in the `Operation` class.
This group of operations is called for the moment "Info", since they mostly provide information about the dataframe, such as the names and types of the defined columns.
To start the implementation of one of those, this PR supports `GetColumnType` calls on PyRDF nodes.
A very basic algorithm to support this feature has been implemented in the Proxy module. When a new `Info` operation is created, since it is not actually a modification of the data, it is not wrapped in a `Proxy`.
Instead `_trigger_info_operation` function is called, that triggers the creation of PyROOT objects for all the nodes defined until this moment.
In this way, `GetColumnType` can be correctly called on the PyROOT object linked to the PyRDF node.
If the logic is accepted, new tests will be added to check this functionality.
Following is a sample script to test the new operation:
```
import PyRDF
rdf = PyRDF.RDataFrame(100)
mydef = rdf.Define("x","rdfentry_ * 2")
mycoltype = mydef.GetColumnType("x")
print(mycoltype) # ULong64_t
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Other Operations" family of functions in the ROOT RDataFrame class has been added to PyRDF in the
Operationclass.This group of operations is called for the moment "Info", since they mostly provide information about the dataframe, such as the names and types of the defined columns.
To start the implementation of one of those, this PR supports
GetColumnTypecalls on PyRDF nodes.A very basic algorithm to support this feature has been implemented in the Proxy module. When a new
Infooperation is created, since it is not actually a modification of the data, it is not wrapped in aProxy.Instead
_trigger_info_operationfunction is called, that triggers the creation of PyROOT objects for all the nodes defined until this moment.In this way,
GetColumnTypecan be correctly called on the PyROOT object linked to the PyRDF node.If the logic is accepted, new tests will be added to check this functionality.
Following is a sample script to test the new operation: