WCAG. Update standard types methods

[MaximPlusov]

Summary by CodeRabbit

• Refactor
  • Simplified PDF structure type validation logic by removing scenario-specific exceptions. Standard type determination now applies uniform classification rules across all validation contexts, potentially affecting how certain element types are categorized during compliance checks.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Two Java methods in PDF structure element validation classes had WCAG flavour-specific conditional logic removed. GFPDStructElem.hasStandardType now relies purely on PDStructElem.isStandardStructureType without WCAG exceptions. GFPDStructTreeNode.getkidsStandardTypes no longer conditionally filters ARTIFACT types based on WCAG mode.

Changes

Cohort / File(s)	Summary
WCAG-specific logic removal in structure element validation validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDStructElem.java, validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDStructTreeNode.java	Removed WCAG flavour conditional branches: hasStandardType no longer excludes non-standard TITLE types in WCAG mode; getkidsStandardTypes no longer filters ARTIFACT types conditionally, potentially changing standard type calculations for both WCAG and non-WCAG validations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Impact on WCAG validation: Verify that removing the WCAG-specific exception for TITLE types in hasStandardType does not break WCAG 2.1 compliance checking, particularly for tagged PDF validation.
• ARTIFACT type inclusion: Confirm that including ARTIFACT types in getkidsStandardTypes results aligns with PDF specification and does not cause false positives/negatives in structure tree validation.
• Test coverage: Ensure existing test cases for WCAG flavour validation pass with these logic changes.
• Downstream re-mapping: Review any code that consumes the hasStandardType and getkidsStandardTypes results to ensure the behavioral changes are compatible.

Poem

🐰 Conditional branches trimmed with care,
WCAG logic stripped bare—
Standard types now unified and true,
Simpler paths for validation to pursue! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: updates to standard types methods related to WCAG functionality in the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch wcag

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c4e1cb and 1e7936f.

📒 Files selected for processing (2)

• validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDStructElem.java (0 hunks)
• validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDStructTreeNode.java (0 hunks)

💤 Files with no reviewable changes (2)

• validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDStructElem.java
• validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDStructTreeNode.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Checkout and Build (8)
• GitHub Check: Checkout and Build (11)
• GitHub Check: Checkout and Build (21)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}