Document available functions and issue a warning when args are missing #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mstruebing is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
mstruebing
force-pushed
the
validation-docs
branch
from
514e6e5 to
c6889c2
Compare
mstruebing
force-pushed
the
validation-docs
branch
from
c6889c2 to
867bbe9
Compare
mstruebing
changed the title
|
|
||
| minLength: (min: number, message?: string): ValidationCheck => ({ | ||
| fn: "minLength", | ||
| fn: 'minLength', |
Contributor
There was a problem hiding this comment.
Check helper functions use incorrect argument keys that don't match what validation functions expect, causing all validations using helpers to fail silently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my journey to get validation to work this would have been quite helpful.
I guess this is true for others as well, so I've created a PR.
cc @ctate