fix: warn when --lan and --wildcard are used together#237
Open
octo-patch wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: warn when --lan and --wildcard are used together#237octo-patch wants to merge 1 commit intovercel-labs:mainfrom
octo-patch wants to merge 1 commit intovercel-labs:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215
Problem
--lanmode uses mDNS (.localdomains) to make services accessible to other devices on the local network. However, mDNS does not support wildcard records — only explicitly registered route hostnames are resolvable on other devices.When a user passes both
--lanand--wildcardtoportless proxy start, the wildcard subdomain fallback silently has no effect for LAN clients (other devices can't resolve the wildcard subdomains via mDNS). There was no indication of this limitation.Solution
--lanand--wildcardare used together:--wildcardflag description in theruncommand help to note "(local only, not LAN)"PORTLESS_WILDCARDenv var description similarlyproxy starthelp to note LAN mode incompatibility with--wildcardTesting
Added a new test
warns when --lan and --wildcard are both providedfollowing the same pattern as the existingwarns when --lan and --tld are both providedtest. All 402 tests pass.