Skip to content

feat: support for Rsbuild#245

Open
zjy040525 wants to merge 1 commit intovercel-labs:mainfrom
zjy040525:feature/add-rsbuild
Open

feat: support for Rsbuild#245
zjy040525 wants to merge 1 commit intovercel-labs:mainfrom
zjy040525:feature/add-rsbuild

Conversation

@zjy040525
Copy link
Copy Markdown

Closes #244

Copilot AI review requested due to automatic review settings April 23, 2026 06:32
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

@zjy040525 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​rsbuild/​core@​2.0.01001008598100

View full report

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class support for running Rsbuild apps behind portless by injecting the required CLI flags (since Rsbuild doesn’t honor injected PORT/HOST env vars), and verifies the behavior via a new e2e fixture and test.

Changes:

  • Add rsbuild to the framework-aware CLI flag injection list so --port/--host are appended when needed.
  • Add a unit test covering injectFrameworkFlags behavior for rsbuild.
  • Add an e2e Rsbuild fixture + test to validate serving through the proxy, and update the e2e proxy port allocation comment.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/e2e/src/rsbuild.test.ts New e2e test that starts an Rsbuild dev server via portless and asserts proxy serving.
tests/e2e/src/harness.ts Update comment documenting the allocated proxy port range to include the new test.
tests/e2e/package.json Add @rsbuild/core so the e2e environment can run the rsbuild CLI.
tests/e2e/fixtures/rsbuild-app/src/index.ts Add minimal entry file required for Rsbuild dev server startup.
tests/e2e/fixtures/rsbuild-app/src/index.html Add minimal HTML template content used by the e2e assertion.
tests/e2e/fixtures/rsbuild-app/rsbuild.config.ts Add minimal Rsbuild config pointing at the HTML template.
pnpm-lock.yaml Lockfile updates for @rsbuild/core and transitive dependencies.
packages/portless/src/cli-utils.ts Add rsbuild to frameworks requiring CLI port/host injection.
packages/portless/src/cli-utils.test.ts Add unit test asserting injected args for rsbuild without --strictPort.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Rsbuild

2 participants