feat: support for Rsbuild#245
Open
zjy040525 wants to merge 1 commit intovercel-labs:mainfrom
Open
Conversation
|
@zjy040525 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds first-class support for running Rsbuild apps behind portless by injecting the required CLI flags (since Rsbuild doesn’t honor injected PORT/HOST env vars), and verifies the behavior via a new e2e fixture and test.
Changes:
- Add
rsbuildto the framework-aware CLI flag injection list so--port/--hostare appended when needed. - Add a unit test covering
injectFrameworkFlagsbehavior forrsbuild. - Add an e2e Rsbuild fixture + test to validate serving through the proxy, and update the e2e proxy port allocation comment.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/src/rsbuild.test.ts | New e2e test that starts an Rsbuild dev server via portless and asserts proxy serving. |
| tests/e2e/src/harness.ts | Update comment documenting the allocated proxy port range to include the new test. |
| tests/e2e/package.json | Add @rsbuild/core so the e2e environment can run the rsbuild CLI. |
| tests/e2e/fixtures/rsbuild-app/src/index.ts | Add minimal entry file required for Rsbuild dev server startup. |
| tests/e2e/fixtures/rsbuild-app/src/index.html | Add minimal HTML template content used by the e2e assertion. |
| tests/e2e/fixtures/rsbuild-app/rsbuild.config.ts | Add minimal Rsbuild config pointing at the HTML template. |
| pnpm-lock.yaml | Lockfile updates for @rsbuild/core and transitive dependencies. |
| packages/portless/src/cli-utils.ts | Add rsbuild to frameworks requiring CLI port/host injection. |
| packages/portless/src/cli-utils.test.ts | Add unit test asserting injected args for rsbuild without --strictPort. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244