Inject --port and --ip for wrangler dev (fixes #263)#272
Open
ericclemmons wants to merge 1 commit intovercel-labs:mainfrom
Open
Inject --port and --ip for wrangler dev (fixes #263)#272ericclemmons wants to merge 1 commit intovercel-labs:mainfrom
ericclemmons wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Wrangler does not honor the PORT env var, so portless was unable to route the auto-assigned port to wrangler-based apps. Add wrangler to the framework auto-injection table. Wrangler uses --ip for the bind address (its --host flag refers to the route hostname, not where to listen), so introduce a per-framework hostFlag override and use --ip 127.0.0.1 for wrangler. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@ericclemmons is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PORTas--portfor wrangler #263. Wrangler does not honor thePORTenv var, so portless was unable to route the auto-assigned port to wrangler-based apps.wranglerto the framework auto-injection table so portless appends--port <port>to the spawned command.--ipfor the bind address (its--hostflag refers to the route hostname, not where to listen), so this PR also introduces a per-frameworkhostFlagoverride and emits--ip 127.0.0.1for wrangler.--helpoutput to reflect the new framework.Test plan
pnpm --filter portless test(599 tests pass, including 4 new wrangler cases incli-utils.test.ts)pnpm lintpnpm --filter portless run type-checkpnpm --filter portless run buildportless run wrangler devagainst a Worker project on a fresh proxy and confirm the dashboard shows the auto-assigned port🤖 Generated with Claude Code