Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bensabic
left a comment
There was a problem hiding this comment.
Thanks for fixing the duplicate content issue on create paths. I think there’s still one gap on editMessage.
In packages/adapter-discord/src/index.ts, the card branch now omits payload.content entirely when PATCHing an existing message. Discord’s Edit Message API treats fields as optional and nullable, so leaving content out does not reliably clear the previous body. If a normal text message is edited into a card, the old text can still remain alongside the embed/components.
I think this should explicitly clear content in the edit path ("" or null, depending on what we want to standardize on), and the test should cover editing a non-empty text message into a card rather than only asserting that the outgoing payload omits content.
Resolves #246