Replace isExternalChannel with channelVisibility enum#298
Merged
nandorojo merged 2 commits intov0/fernandorojo-867fa5c0from Mar 25, 2026
Merged
Conversation
Slack-Thread: https://vercel.slack.com/archives/C0ACY4D798Q/p1771867586825769?thread_ts=1771867586.825769&cid=C0ACY4D798Q Co-authored-by: Kavin Valli <41034356+kavinvalli@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Slack-Thread: https://vercel.slack.com/archives/C0ACY4D798Q/p1771867586825769?thread_ts=1771867586.825769&cid=C0ACY4D798Q Co-authored-by: Kavin Valli <41034356+kavinvalli@users.noreply.github.com>
vercel
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the boolean
isExternalChannelfield with a more flexiblechannelVisibilityenum.What changed
ChannelVisibilitytype with values:private,workspace,external,unknownchannelVisibilityfield toThread,Channel,ThreadInfo,ChannelInfo, and serialization typesgetChannelVisibility()method to theAdapterinterfacegetChannelVisibility()in Slack adapter with detection of private channels (G*), DMs (D*), public channels (C*), and external Slack Connect channelsisExternalChannelreferences (no backwards compatibility needed since PR Add channelVisibility support to Thread, Channel, and Slack adapter #51 hasn't merged)