-
Notifications
You must be signed in to change notification settings - Fork 30k
Fix: Unhandled errors within a Suspense aren't appearing consistently in OTEL traces/spans #86596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1sahilsanjeev
wants to merge
4
commits into
vercel:canary
Choose a base branch
from
1sahilsanjeev:fix/issue-86517-21f40d76
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2ec7070
modify: packages/next/src/server/lib/trace/tracer.ts - Issue #86517
1sahilsanjeev f5c5c53
modify: packages/next/src/server/app-render/app-render.tsx - Issue #8…
1sahilsanjeev 5b50bad
modify: packages/next/src/client/components/error-boundary.tsx - Issu…
1sahilsanjeev f33d965
modify: packages/next/src/server/lib/trace/constants.ts - Issue #86517
1sahilsanjeev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ErrorBoundaryHandler class has severe structural corruption with incomplete method definitions, duplicate declarations, and orphaned code fragments that will prevent compilation.
View Details
📝 Patch Details
Analysis
ErrorBoundaryHandler class has severe structural corruption with incomplete method definitions and duplicate declarations
What fails:
packages/next/src/client/components/error-boundary.tsxfails to compile due to malformed ErrorBoundaryHandler class with incompletegetDerivedStateFromErrormethod, missingresetmethod, orphaned code fragments, and duplicateErrorBoundaryfunction declarations.How to reproduce:
Result: TypeScript compiler fails with syntax errors -
getDerivedStateFromErrormethod starts withtry {block at line 55 but immediately transitions tostatic getDerivedStateFromPropswithout proper closure, orphaned incomplete code at lines 96-99 with stray() => {fragments, duplicaterender()method signatures at lines 127-129, and duplicateErrorBoundaryfunction declarations.Expected: File should compile successfully and match the structure from commit dcece12, with complete method definitions:
getDerivedStateFromError,getDerivedStateFromProps,reset, singlerender()method, and singleErrorBoundaryfunction.The file was corrupted by commit 5b50bad ("modify: packages/next/src/client/components/error-boundary.tsx - Issue #86517") which attempted to add OTEL tracing support but left the file in an incomplete, syntactically invalid state.