Draft
Conversation
Member
|
@cmcWebCode40 following our conversation last time about the difference between the "Select Wallet" modal and the "Select Address" modal which are supposed to be relatively similar but had some differences in the Figma design, Oleksander made an update so they do have a similar design and behaviour. Can you look at the Figma and apply the changes. I will continue the review afterwards |
aurelticot
requested changes
Dec 15, 2022
- modified alert component logic - removed custom styles and also change modal close icon - Add verida one url constant - modified banner component profile screen link #764
Contributor
Author
|
i have completed the requested changes , please can you review ? |
- updated claimbadge screen params types
added 7 commits
April 16, 2023 11:48
6 tasks
Member
|
Rely on #874 |
…badges-flow # Conflicts: # src/components/WalletList/types.ts # src/components/WalletModal/ImportWalletModal.tsx # src/constants/url.js # src/navigation/types.ts # src/pages/Wallets/ManageWallets.tsx # src/pages/Wallets/SingleWallet.tsx # src/reduxStore/wallet/selectors.js # src/styles/button.js
…ure/764-claim-badges-flow # Conflicts: # package.json # src/pages/Assets/Collectibles.tsx # src/pages/Data/CredentialDataItem.tsx # yarn.lock
Closed
…badges-flow # Conflicts: # src/navigation/MainNavigator.tsx
…badges-flow # Conflicts: # src/pages/Connections/SingleConnection.js
Contributor
|
Things I work on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
closes #764
Note: No actual functionalities have been implemented.
Note from PR #874
Closes #868
Depends on Data connector server update: verida/data-connector-server#47
Demo
https://www.loom.com/share/6c8a592324d941c7a0317a880f19bb67