[Scatter-Gather] [Hotfix] Fix issue parsing the wireconn tag #3248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libarchfpga
|
It seems there is still a CI failure: Test 'vtr_reg_strong' had -1 qor test failures Test 'vtr_reg_strong' had 0 run failures |
|
It worked locally on my machine but apparently there's an issue. Seems like the fix wasn't really that hot. |
|
Hi @AmirhosseinPoolad : probably if this can't be fixed soon you should disable this test temporarily so CI doesn't have spurious failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scatter-gather parsing logic was just skipping parsing the from/to tags of wireconn specification. There was also a typo where I checked gather_wireconn twice and scatter_wireconn zero times. Not sure how it passed CI before. I noticed a failure when running strong tests locally.