Skip to content

Conversation

SamuelHo10
Copy link
Contributor

@SamuelHo10 SamuelHo10 commented Aug 22, 2025

  • Test the full place and route flow, the analysis only flow etc. with graphics and make sure the status bar messages come out at the right time (should say "placement complete, estimated critical path is xx" and then "routing succeeded with a channel width of yy" etc.). When you demoed the graphics, the routing success message instead showed up after you hit next step, just before the program exited.
  • Test that the critical path display works, both with flylines and with routed nets. Move the critical path display options under nets and make them similar (checkbox for delays, drop down for flyline vs. routed & a toggle for critical path shown or not) to the existing net controls. Use a vertical separator to divide them from other net controls. Probably the flyline vs. routed option can just be tied to the existing net option / dropdown for that -- that might be less cluttered and less confusing.

Previously, we had options to show flylines and routing for critical path at the same time which I think might be a useful feature to keep, so I used checkboxes for the flylines/routing.

  • Add a status bar message when you choose select zoom that tells you what to do (left click on the two diagonally opposite corners of the desired zoom)
  • Update the documentation to describe all the various graphics options

I only had the time to update the documentation for the Nets and Routing Resource section.

Other minor changes include fixing the highlight functionality when multiple nodes are selected using ctrl + click, and ensuring that the intra-cluster flyline nets option is available even when flat routing is off.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool docs Documentation lang-cpp C/C++ code labels Aug 22, 2025
@SamuelHo10 SamuelHo10 linked an issue Aug 22, 2025 that may be closed by this pull request
14 tasks
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one typo.

When a placement is being displayed, routing information is not yet known so nets are simply drawn as a “star;” that is, a straight line is drawn from the net source to each of its sinks.
Click on any clb in the display, and it will be highlighted in green, while its fanin and fanout are highlighted in blue and red, respectively.
Once a circuit has been routed the true path of each net will be shown.
If routing is shown, clicking on a pin or channel wire whill highlight the whole net in magenta.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whill -> will

@vaughnbetz
Copy link
Contributor

Thanks a lot @SamuelHo10 ! Lots of nice fixes here. Merging this, and we can fix the typo @AlexandreSinger found in a separate PR.

@vaughnbetz vaughnbetz merged commit 3ef09be into master Aug 23, 2025
30 checks passed
@vaughnbetz vaughnbetz deleted the final_graphics_clean_up branch August 23, 2025 23:51
@AlexandreSinger
Copy link
Contributor

AlexandreSinger commented Aug 24, 2025

Thanks a lot @SamuelHo10 ! Lots of nice fixes here. Merging this, and we can fix the typo @AlexandreSinger found in a separate PR.

Done: #3253
Have a great rest of your summer @SamuelHo10 , thanks for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphics to do list
3 participants