[CI] Moved to Use Standard Package Installer Script #3252
+112
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
Found that the CI was using a separate script which was indirectly calling the standard package install script. This can cause the standard package install script to regress, but it was also causing pressure on the GitHub runners by having them install more packages than they needed.
AlexandreSinger
force-pushed
the
feature-ci-packages
branch
from
515b256 to
5e3d03a
Compare
AlexandreSinger
changed the title
AlexandreSinger
force-pushed
the
feature-ci-packages
branch
from
47534c3 to
65eea69
Compare
| run: ./.github/scripts/install_dependencies.sh | ||
| run: | | ||
| ./install_apt_packages.sh | ||
| sudo apt-get install qtbase5-dev |
There was a problem hiding this comment.
Should we do a sudo apt update here to be safe?
There was a problem hiding this comment.
Not a bad idea! Technically we dont since install_apt_packages does as well, but we might as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that the CI was using a separate script which was indirectly calling the standard package install script. This can cause the standard package install script to regress, but it was also causing pressure on the GitHub runners by having them install more packages than they needed.