Skip to content

Conversation

loglav03
Copy link
Contributor

Description

Removed all top module mapping code in synthesis.tcl and slang_filelist.tcl for Slang.

Related Issue

Motivation and Context

Since top module mapping isn't required for slang, any unused code for this that made it to master needs to be removed to reduce clutter.

How Has This Been Tested?

Passes the system verilog regression test that uses slang as a parser.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [ x] All new and existing tests passed

@loglav03 loglav03 changed the title [WIP] Removing Top Module Mapping With Slang Removing Top Module Mapping With Slang Aug 28, 2025
@loglav03 loglav03 marked this pull request as ready for review August 28, 2025 22:26
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @loglav03

@AlexandreSinger AlexandreSinger merged commit 22e0cfb into master Aug 29, 2025
30 checks passed
@AlexandreSinger AlexandreSinger deleted the slang_top_map_removal branch August 29, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants