Conversation
## Walkthrough
The ingress configuration in the deployment's `values.yaml` file was updated by setting the `enabled` field to `true` and changing the ingress host from `"blossom.plur.app"` to `"blossom.verse.app"`. This change activates ingress for the deployment with a new host address. Additionally, a trailing newline was removed from the `service.yaml` file without modifying its content or structure. A new Kubernetes Certificate resource manifest was added to define a TLS certificate for the ingress host, specifying certificate details and referencing a ClusterIssuer for automatic certificate management. The ingress manifest was modified to replace the ingress class annotation with the `ingressClassName` field and to add TLS configuration referencing the new certificate.
## Changes
| File(s) | Change Summary |
|---------------------------------------------|-----------------------------------------------------------------------------------------------------------------|
| deployment/route96/values.yaml | Enabled ingress by setting `ingress.enabled` from `false` to `true` and updated `ingress.host` from `"blossom.plur.app"` to `"blossom.verse.app"`. |
| deployment/route96/templates/service.yaml | Removed trailing newline at the end of the file; no content changes. |
| deployment/route96/templates/certificate.yaml, deployment/route96/templates/ingress.yaml | Added a new Kubernetes Certificate resource manifest for cert-manager named `blossom-certificate` with TLS details for `blossom.verse.app`. Modified ingress manifest to replace `kubernetes.io/ingress.class` annotation with `ingressClassName` field and added TLS configuration referencing the new certificate secret. |
## Possibly related PRs
- verse-pbc/route96#1: Introduces the initial Helm chart and Kubernetes manifests for deploying the Blossom media server, including ingress resources but without TLS and ingress class refinements; this PR builds upon and modifies those templates.
## Suggested reviewers
- dcadenas
## Poem
> A toggle flipped, ingress is live,
> Now traffic can flow, connections arrive.
> Through YAML’s gates, the routes align,
> Services greet the world in kind.
> 🐇 With a hop and a skip, the network sings—
> Welcome, new ingress, to wonderful things!
> And certificates shine bright, secure and true,
> Blossoming paths, fresh and new! Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
deployment/route96/values.yaml (1)
24-27: 🛠️ Refactor suggestionAdd TLS configuration for secure ingress
Unencrypted HTTP toblossom.plur.appisn’t ideal for production. It’s recommended to define atlsstanza that references a Kubernetes Secret (e.g., provisioned via cert‑manager) so traffic is served over HTTPS:ingress: enabled: true className: "nginx" host: "blossom.plur.app" + tls: + - hosts: + - "blossom.plur.app" + secretName: blossom-tls
🧹 Nitpick comments (1)
deployment/route96/values.yaml (1)
26-26: Document DNS record requirement
The PR summary notes a pending Cloudflare DNS record. Please update the README or add aTODOin this file to create an A/CNAME record forblossom.plur.apppointing at your ingress controller’s external IP.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
deployment/route96/values.yaml(1 hunks)
🔇 Additional comments (2)
deployment/route96/values.yaml (2)
24-24: Enable ingress for external access
Enabling ingress is the correct step to expose the Blossom service. Before merging, please verify that the ingress‑nginx controller is deployed and healthy in the target cluster.
25-27: Validate Helm chart ingress schema
Ensure that the chart’svalues.yamlexpects a singularhostand aclassNamekey. Some charts instead require an array underhostsor useingressClassName. Double‑check the chart’s values schema and adjust accordingly—for example:ingress: enabled: true ingressClassName: nginx hosts: - host: "blossom.plur.app" paths: - path: /
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
deployment/route96/templates/service.yaml (1)
16-16: Add missing newline at end-of-fileThe static analysis tool reports a missing trailing newline. While this change has no impact on the Service manifest’s behavior, adding a newline at EOF ensures compliance with POSIX conventions and satisfies
yamllint’snew-line-at-end-of-filerule.@@ -15,1 +15,2 - type: ClusterIP + type: ClusterIP +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 16-16: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
deployment/route96/templates/service.yaml(1 hunks)deployment/route96/values.yaml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- deployment/route96/values.yaml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
deployment/route96/templates/service.yaml
[error] 16-16: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
deployment/route96/templates/certificate.yaml (2)
21-25: Fix indentation underdnsNames.
YAMLLint reports “wrong indentation” for the list item on line 25. The list entry must be indented two spaces further than its key:dnsNames: - - blossom.verse.app + - blossom.verse.appAlso, verify this DNS name matches the host in your Ingress values (
blossom.verse.app).🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 25-25: wrong indentation: expected 4 but found 2
(indentation)
28-28: Add a trailing newline at end of file.
YAML parsers and linters expect a final newline.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 28-28: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
deployment/route96/templates/certificate.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
deployment/route96/templates/certificate.yaml
[warning] 25-25: wrong indentation: expected 4 but found 2
(indentation)
[error] 28-28: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (4)
deployment/route96/templates/certificate.yaml (4)
1-9: Header and metadata look good.
TheapiVersion,kind,metadata.name, andlabelscorrectly define a newCertificateresource.
10-17: Private key and certificate duration settings are correct.
Using RSA/PKCS1 with a 2048‑bit key, 90‑day validity, and 15‑day renewal window aligns with best practices for Let's Encrypt certificates.
18-20: Usages block is valid.
Specifying bothserver authandclient authis appropriate for a public‑facing Ingress certificate.
26-28: Issuer reference is correctly configured.
Referencing theletsencrypt-prodClusterIssuer is appropriate for automated ACME certificate issuance.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 28-28: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
deployment/route96/templates/ingress.yaml(2 hunks)
🔇 Additional comments (1)
deployment/route96/templates/ingress.yaml (1)
26-26: Verify support foringressClassName.You’ve removed the old
kubernetes.io/ingress.classannotation in favor ofspec.ingressClassName, which is the newer convention. Please confirm that your target Kubernetes version (and ingress-nginx controller) supportsingressClassName. If you need to maintain compatibility with older clusters, consider documenting the minimum supported version or retaining the annotation as a fallback.
1 participant
This exposes Blossom over the internet, by enabling the Ingress manifest, which will configure the ingress-nginx reverse proxy in the cluster to route to the Blossom Pod, based on the values.yaml file values.
Summary by CodeRabbit