Conversation
aversecat
force-pushed
the
auke/ipv6
branch
2 times, most recently
from
9452997 to
b79fcee
Compare
The size of this thing is well over 1kb, and the compiler will error on several supported distributions that this particular function reaches over 2k stack frame size, which is excessive, even for a function that isn't called regularly. We can allocate the thing in one go if we smartly allocate this as an array of (an array of structs) which allows us to index it as a 2d array as before, taking away some of the additional complexities. Signed-off-by: Auke Kok <auke.kok@versity.com>
This change adds ipv6 support to various scoutfs sub-commands, allowing users to mkfs, print and change-quorum-config using ipv6 addresses, and modifies the outputs. Any ipv6 address/port is displayed as [::1]:5000 to comply with the related RFC's. Input strings remain consistent as the quorum config input value is comma-separated already, not posing any issues. Signed-off-by: Auke Kok <auke.kok@versity.com>
Instead of using 127.0.0.1, we initialize the quorum slots to ::1, enabling all ipv6 support. Signed-off-by: Auke Kok <auke.kok@versity.com>
This adds IPv6 support to the kernel module side. Signed-off-by: Auke Kok <auke.kok@versity.com>
These 2 kernel wrapper functions need to be able to properly handle the ipv6 addrlen, instead of returning -EAFNOSUPPORT(-97). Signed-off-by: Auke Kok <auke.kok@versity.com>
Contributor
Author
|
retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
::1but scratch mounts are ipv4.