Skip to content

scoutfs: introduce CodingStyle.txt#28

Closed
agrover wants to merge 1 commit intomainfrom
zab/codingstyle
Closed

scoutfs: introduce CodingStyle.txt#28
agrover wants to merge 1 commit intomainfrom
zab/codingstyle

Conversation

@agrover
Copy link

@agrover agrover commented Mar 31, 2021

Add a coding style document that tries to record the conventions that
the project uses. It seemed more appropriate to put it up in the -kmod
git repo context rather than in src/ which would end up in fs/scoutfs/
upstream.

Signed-off-by: Zach Brown zab@versity.com

Add a coding style document that tries to record the conventions that
the project uses.  It seemed more appropriate to put it up in the -kmod
git repo context rather than in src/ which would end up in fs/scoutfs/
upstream.

Signed-off-by: Zach Brown <zab@versity.com>
@agrover
Copy link
Author

agrover commented Mar 31, 2021

copying PR from PR against old repo I think the only question is exactly where to put it. Why not toplevel?

@versity-github
Copy link

@zabbo
Copy link
Collaborator

zabbo commented Mar 31, 2021

copying PR from PR against old repo I think the only question is exactly where to put it. Why not toplevel?

Well, I'd first ask if we want it to begin with. It landed with a resounding thud when I first threw it together. Is it needed?

@agrover
Copy link
Author

agrover commented Apr 7, 2021

Yeah I think it's a good idea. To just have a place to put style preferences. We may come up with more.

I think I just read the PR and got the info that way but that's kinda cheating or something.

@versity-github
Copy link

@versity-github
Copy link

Can one of the admins verify this patch?

@versity-github
Copy link

This won't automatically run in continuous integration without approval. A member of the Versity organization must allow it.

@zabbo
Copy link
Collaborator

zabbo commented Mar 5, 2024

This is ancient and I don't think we'll be doing this.

@zabbo zabbo closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants