-
Notifications
You must be signed in to change notification settings - Fork 1
feat: enhance CLI with STS authentication and improved configuration #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Michaël Vachette <5880528+michaelva@users.noreply.github.com>
- Add support for STS (Security Token Service) for API key authentication - Add global CLI options: --site, --studio-url, --store-url, --sts-url, --apikey - Update VertesiaClient to support stsUrl parameter with proper URL derivation: - Production: https://sts.vertesia.io - Preview: https://sts-preview.vertesia.io - Staging: https://sts-staging.vertesia.io (default for branch envs) - Fix getAuthToken to use /token/issue endpoint with Authorization Bearer header - Remove requirement for --project and --account when using --apikey (auto-extracted from JWT) - Make account and project fields optional in Profile interface - Improve error messages to include STS URL for better debugging - Support environment variables: VERTESIA_SITE, STS_SERVER_URL 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ChangesThis pull request introduces several enhancements and fixes across multiple packages in the Vertesia ecosystem. It updates package versions, improves CLI functionality by adding global options for API configuration (site, studio-url, store-url, sts-url, apikey) to allow users to override server URLs via command-line flags, enhances the Vertesia client with the ability to work with STS (Security Token Service), and introduces an Here is a breakdown of the changes:
PurposeThe primary motivation behind this pull request is to enhance the CLI tool by adding support for STS (Security Token Service) authentication. This allows for more secure and flexible API key handling. Additionally, the PR aims to improve the CLI's configurability by introducing global options for server configuration, removing the necessity for users to manually specify project and account IDs when using an API key, and improving the overall authentication process. The context of this pull request involves addressing limitations in the existing CLI tool, particularly in how it handles API key authentication and server configuration. By integrating STS authentication and providing global CLI options, the PR aims to simplify the user experience and make the CLI more adaptable to different environments (production, preview, staging). The changes include modifying the authentication process to use the Authorization Bearer header with POST requests, which is deemed more secure and standard. Related issues: N/A Code ReviewYou can start a code review by adding a comment: "Vertesia, please review". Note that the motivation and context are rated as very clear (5/5). The agent has a very good understanding of the purpose of the pull request. |
Summary
Changes
CLI Enhancements
--site,--studio-url,--store-url,--sts-url,--apikeyoptionsVERTESIA_SITE,STS_SERVER_URL--projectand--accountwhen using--apikeySTS Integration
https://sts.vertesia.iohttps://sts-preview.vertesia.iohttps://sts-staging.vertesia.io(default for branch environments)getAuthToken()to use/token/issueendpointClient Improvements
stsUrlparameter toVertesiaClientPropsaccountandprojectoptional in Profile interfaceTest Plan
🤖 Generated with Claude Code