Skip to content

Conversation

@mincong-h
Copy link
Contributor

when sending a PR to preview (baseRef), the assistance should be enabled.

when sending a PR to preview (baseRef), the assistance should
be enabled.
@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
demo-github-server Ignored Ignored Preview Dec 3, 2025 4:03pm

@vertesia-code-review
Copy link

vertesia-code-review bot commented Dec 3, 2025

Changes

This pull request includes changes to the test workflow and the pull request review workflow in the github-agent application. The test workflow is updated to use the preview environment and a newer version of the Vertesia CLI. The pull request review workflow now skips assistance for pull requests from main to preview branches, aligning with the policy of not supporting code review for the preview branch due to frequent changes.

Here is a breakdown of the changes:

Path Description
.github/workflows/test.yaml Updates the test workflow:
  • Changes the VT_ENV environment variable from staging to preview.
  • Updates the VT_PROFILE to preview-experiments.
  • Updates the VT_CLI_VERSION to 0.79.3.
    apps/github-agent/src/workflows/review-pull-request.ts | Modifies the shouldSkipAssistance function to skip pull requests from main to preview branches. This change prevents code reviews for sync PRs from main to preview.

Purpose

The motivation for this pull request is to ensure that assistance is enabled for preview pull requests. This enhancement aims to improve the development workflow by providing assistance when sending a pull request to preview (baseRef).

The context of this pull request is to address the issue where assistance was not enabled for preview pull requests. By enabling assistance for these PRs, developers can benefit from the same level of support and guidance as they would for other types of pull requests, leading to more efficient and effective code review and collaboration.

Related issues: N/A

Code Review

You can start a code review by adding a comment: "Vertesia, please review".

Note that the motivation and context are rated as very clear (5/5). The agent has a very good understanding of the purpose of the pull request.

@mincong-h mincong-h requested a review from Copilot December 3, 2025 15:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the logic for when code review assistance is skipped during pull requests. Previously, all PRs targeting the preview branch were skipped. Now, assistance is only disabled when syncing from main to preview, allowing assistance for other PRs targeting preview.

Key Changes:

  • Modified the condition to skip assistance only for mainpreview sync PRs
  • Updated the skip reason message to be more specific about which PRs are excluded

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mincong-h mincong-h merged commit 20ac9b8 into main Dec 3, 2025
7 checks passed
@mincong-h mincong-h deleted the pr-trigger branch December 3, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants