-
Notifications
You must be signed in to change notification settings - Fork 83
Initial open fd monitoring w/ cell write lock (SYN-10120) #4684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4684 +/- ##
==========================================
- Coverage 97.72% 97.66% -0.06%
==========================================
Files 296 296
Lines 62114 62172 +58
==========================================
+ Hits 60701 60721 +20
- Misses 1413 1451 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: blackout <blackout@vertex.link>
|
We should disable/not start the FD monitoring if the limit is already set to unlimited. |
|
@MichaelSquires that would be safe if we assume that no one will ever change the soft limit of the process while it is running. If we do decide to bail in that case we should include in docs that monitoring isn't done if the soft limit is set to unlimited. |
No description provided.