Fix implicit precision conversions in S3D OpenCL kernels #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied CPREC() wrapper to all floating point literals in ratx.cl, ratxb.cl and ratt.cl files where they were previously missing. At some places, floating literals like 2.6e0 werent wraped with CPREC macro. By default, the convention is to handle these literals as type double. This can cause the computations to be carried out on double precision pipeline. This fix ensures: - Proper precision handling in both single and double precision modes - Prevention of double precision pipeline usage for single precision test. - Prevention of unnecessary double-to-single precision conversions for single precision test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied CPREC() wrapper to all floating point literals in ratx.cl, ratxb.cl and ratt.cl files where they were previously missing.
At some places, floating literals like 2.6e0 werent wraped with CPREC macro. By default, the convention is to handle these literals as type double. This can cause the computations to be carried out on double precision pipeline.
This fix ensures: