fix: add docker build for Debian image#46
Merged
Mohammed Naser (mnaser) merged 19 commits intovexxhost:mainfrom Jan 25, 2026
Merged
fix: add docker build for Debian image#46Mohammed Naser (mnaser) merged 19 commits intovexxhost:mainfrom
Mohammed Naser (mnaser) merged 19 commits intovexxhost:mainfrom
Conversation
Michiel Piscaer (mpiscaer)
force-pushed
the
fix/debian
branch
from
eea0985 to
dd065f5
Compare
Member
|
I like the approach here overall, but I have a few ideas:
I'll be getting a bindep image up in a sec and I'll amend to this PR |
Mohammed Naser (mnaser)
force-pushed
the
fix/debian
branch
from
dd065f5 to
f3b7fcb
Compare
Replace shell conditionals with bindep to dynamically resolve packages based on the target platform. This provides a cleaner and more maintainable approach for handling different OS versions. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
force-pushed
the
fix/debian
branch
from
f3b7fcb to
25ca0f8
Compare
Member
|
Michiel Piscaer (@mpiscaer) this still needs some love i think -- since i'm at this, i want to try and make a "install_packages" helper or find one that already exists so we can have the infrastructure ready to use this for rhel based stuff too while wer'e at it. |
Member
|
also I think i messed up the bindep if you want to give it a shot.. I need to context switch to something else for a mnute |
Mohammed Naser (mnaser)
force-pushed
the
fix/debian
branch
2 times, most recently
from
d9e1938 to
1ad2bcb
Compare
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
force-pushed
the
fix/debian
branch
from
1ad2bcb to
c32596b
Compare
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
…ation Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Add support for: - ubuntu (24.04) - ubuntu-cloud-archive - debian (trixie) - rockylinux (9) - almalinux (9) Update bindep.txt with RHEL-family package names. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
- python-base-ubuntu - python-base-ubuntu-cloud-archive - python-base (legacy, same as ubuntu-cloud-archive) - python-base-debian - python-base-rockylinux - python-base-almalinux Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Avoids leaving packages.txt in the final image layer. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mount uvx directly from uv image instead of copying it. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
uvx requires uv to function. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
No from= parameter means it mounts from context. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Eliminates the separate bindep stage by running bindep inline in the install-packages command. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
- Mount install-packages from context - Mount uv/uvx to /usr/local/bin (in PATH) - Final image only contains installed packages Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
- Remove local install-packages script - Mount from ghcr.io/vexxhost/build-utils:latest - Use install-bindep-packages for simpler invocation Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
|
Michiel Piscaer (@mpiscaer) Digest: |
|
Michiel Piscaer (@mpiscaer) Digest: |
|
Michiel Piscaer (@mpiscaer) Digest: |
|
Michiel Piscaer (@mpiscaer) Digest: |
|
Michiel Piscaer (@mpiscaer) Digest: |
|
Michiel Piscaer (@mpiscaer) Digest: |
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
* fix: add docker build for Debian image (backport #46) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: use Ubuntu 22.04 packages for older stable branches - Use ubuntu:22.04 instead of ubuntu:24.04 - Use libpython3.10 instead of libpython3.12 - Remove libpcre3 (not needed) - Use python3-distutils for Ubuntu (avoid regression) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: use Debian Bookworm and remove pcre - Use debian:bookworm instead of debian:trixie - Use libpython3.11 for Debian Bookworm - Remove pcre from all platforms (not needed) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: simplify bindep to use python3-distutils for dpkg platforms Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> --------- Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> Co-authored-by: Claude <noreply@anthropic.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
* fix: add docker build for Debian image (backport #46) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: use Ubuntu 22.04 and Debian Bookworm for older stable branches - Use ubuntu:22.04 instead of ubuntu:24.04 - Use debian:bookworm instead of debian:trixie - Use libpython3.10 for Ubuntu, libpython3.11 for Debian - Remove pcre from all platforms (not needed) - Use python3-distutils for Ubuntu (avoid regression) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: simplify bindep to use python3-distutils for dpkg platforms Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: resolve merge conflict in Dockerfile Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> --------- Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> Co-authored-by: Claude <noreply@anthropic.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
* fix: add docker build for Debian image (backport #46) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: use Ubuntu 22.04 and Debian Bullseye for older stable branches - Use ubuntu:22.04 instead of ubuntu:24.04 - Use debian:bullseye instead of debian:trixie - Use libpython3.10 for Ubuntu, libpython3.9 for Debian - Remove pcre from all platforms (not needed) - Use python3-distutils for Ubuntu (avoid regression) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: simplify bindep to use python3-distutils for dpkg platforms Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> --------- Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> Co-authored-by: Claude <noreply@anthropic.com>
Mohammed Naser (mnaser)
added a commit
that referenced
this pull request
Jan 25, 2026
* fix: add docker build for Debian image (backport #46) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: use Ubuntu 22.04 and Debian Bullseye for older stable branches - Use ubuntu:22.04 instead of ubuntu:24.04 - Use debian:bullseye instead of debian:trixie - Use libpython3.10 for Ubuntu, libpython3.9 for Debian - Remove pcre from all platforms (not needed) - Use python3-distutils for Ubuntu (avoid regression) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> * fix: simplify bindep to use python3-distutils for dpkg platforms Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> --------- Signed-off-by: Mohammed Naser <mnaser@vexxhost.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: add docker build for Debian image