feat: add more neutron metrics by na50r · Pull Request #64 · vexxhost/openstack_database_exporter

Rosan Shanmuganathan (na50r) · 2026-01-30T09:36:46Z

Adds neutron metrics to the vexxhost openstack database exporter

Most of the neutron metrics from the niedbalski's openstack exporter implemented
Tested on devstack & openstack deployment via kubernetes (openstack helm charts, caracal)

TODO:

Implement tests (unsure how thorough...)
- routers_tests
- networks_tests
- ports_tests
- floating_ips_tests
- security_groups_tests
- subnets_tests
- neutron_up test
Implement missing metrics (Niedbalski 1.6.0)

Comment

I don't think it is possible to get openstack_neutron_agent_state from the DB. See: code

TODO:

Implement missing metrics (Niedbalski 1.8.0-alpha)

Signed-off-by: na50r <shanrosan@gmail.com>

Tadas Sutkaitis (fitbeard) · 2026-02-05T14:39:03Z

Rosan Shanmuganathan (@na50r) we approve your pipeline for a new features later. Thank you for your patience.

Copilot

Pull request overview

Adds additional Neutron-related Prometheus metrics by expanding the Neutron SQL schema/queries, generating db accessors, and introducing new collectors + tests under the Neutron subsystem.

Changes:

Expanded Neutron SQL schema and added multiple new SQL queries (routers, floating IPs, networks, ports, subnets, subnet pools, IP availability).
Added new Neutron collectors (networking umbrella collector + per-resource collectors) and corresponding unit tests.
Updated generated Go query bindings and added supporting model types.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
sql/neutron/schema.sql	Adds Neutron tables needed for new metrics/queries.
sql/neutron/queries.sql	Adds SQL queries powering the new collectors.
internal/db/neutron/queries.sql.go	Generates Go bindings for the new SQL queries.
internal/db/neutron/models.go	Adds model / enum scan helpers for Neutron types.
internal/collector/neutron/networking.go	Adds an umbrella collector emitting a single `neutron_up` and delegating to sub-collectors.
internal/collector/neutron/networks.go	Adds network metrics collector.
internal/collector/neutron/routers.go	Adds router metrics collector; updates HA router-agent binding collector to return errors.
internal/collector/neutron/ports.go	Adds port metrics collector.
internal/collector/neutron/floating_ips.go	Adds floating IP metrics collector.
internal/collector/neutron/subnets.go	Adds subnet + subnet pool capacity metrics collector.
internal/collector/neutron/security_groups.go	Adds security group count collector.
internal/collector/neutron/misc.go	Adds IP availability metrics and related helpers.
internal/collector/neutron/*.go tests	Adds tests for the new collectors and umbrella `neutron_up` behavior.
internal/collector/neutron/neutron.go	Registers the new umbrella collector instead of the single HA collector.
go.mod	Adds `go4.org/netipx` dependency for subnet math.

Comments suppressed due to low confidence (1)

internal/collector/neutron/subnets.go:1

calculateFreeSubnets rebuilds an IP set (add pool, remove all subnets, build) for every prefixLen, which can be expensive for large deployments. Consider building the remaining free IP set once per pool prefix and deriving counts for each prefixLen from that (or caching intermediate results) to reduce repeated work.

package neutron

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T12:42:08Z

internal/collector/neutron/subnets.go

+	for i, pool := range pools {
+		result[i] = subnetpoolWithSubnets{&pool, subnetPrefixes[pool.ID]}


This takes the address of the range loop variable (&pool), which is reused each iteration, so every subnetPool pointer in result ends up pointing to the same (last) pool. Use a stable address (e.g., &pools[i]) or create a new variable per iteration before taking its address.

Suggested change

for i, pool := range pools {

result[i] = subnetpoolWithSubnets{&pool, subnetPrefixes[pool.ID]}

for i := range pools {

pool := &pools[i]

result[i] = subnetpoolWithSubnets{pool, subnetPrefixes[pool.ID]}

Copilot · 2026-02-12T12:42:08Z

internal/db/neutron/models.go

+func (e *SubnetsIpv6AddressMode) Scan(src interface{}) error {
+	switch s := src.(type) {
+	case []byte:
+		*e = SubnetsIpv6AddressMode(s)
+	case string:
+		*e = SubnetsIpv6AddressMode(s)
+	default:
+		return fmt.Errorf("unsupported scan type for SubnetsIpv6AddressMode: %T", src)
+	}


Converting []byte directly to a defined string type won’t compile. Convert via string(s) first (same issue also applies to SubnetsIpv6RaMode.Scan).

This is generated code, if you want it to be different, either complain to those who made sqlc or change the SQL query that generated this. And you are wrong, this code DOES compile.

internal/db/neutron/models.go

Copilot · 2026-02-12T12:42:09Z

sql/neutron/queries.sql

+    s.gateway_ip,
+    s.network_id,
+    s.project_id,
+    s.enable_dhcp;


s.subnetpool_id is selected but not included in GROUP BY and is not aggregated. With MySQL/MariaDB ONLY_FULL_GROUP_BY enabled, this query will error. Either add s.subnetpool_id to the GROUP BY list, or aggregate it (e.g., MAX(s.subnetpool_id) if appropriate).

Suggested change

s.enable_dhcp;

s.enable_dhcp,

s.subnetpool_id;

Copilot · 2026-02-12T12:42:09Z

sql/neutron/queries.sql

+    sp.ip_version,
+    sp.max_prefixlen,
+    sp.min_prefixlen,
+    sp.default_prefixlen;


sp.project_id and sp.name are selected but not included in GROUP BY and not aggregated. This will fail under ONLY_FULL_GROUP_BY (and is nondeterministic otherwise). Add those columns to GROUP BY or use an aggregate/ANY_VALUE() depending on your DB support.

Suggested change

sp.default_prefixlen;

sp.default_prefixlen,

sp.project_id,

sp.name;

Copilot · 2026-02-12T12:42:10Z

internal/collector/neutron/routers_test.go

+func (t *testHARouterAgentPortBindingCollector) Collect(ch chan<- prometheus.Metric) {
+	_ = t.HARouterAgentPortBindingCollector.Collect(ch)
+}


The test wrapper discards errors from Collect, which can make the test pass even if the collector fails. Match the pattern used in other tests (panic/fail the test when Collect returns an error).

Copilot · 2026-02-12T12:42:10Z

internal/collector/neutron/routers_test.go

+func (t *testRouterCollector) Collect(ch chan<- prometheus.Metric) {
+	_ = t.RouterCollector.Collect(ch)
 }


Same issue as above: ignoring the returned error can hide failures. Fail the test if Collect returns an error.

Copilot · 2026-02-12T12:42:11Z

internal/collector/neutron/floating_ips_test.go

+					"02e67ccf829b44438e1c0397b2444a0f",
+					"bd221f59-33c9-4d67-8f9c-ccaea76b05c5",
+					"ACTIVE",
+					"",


Using an empty string for fixed_ip_address makes sql.NullString.Valid true, which changes the collector behavior that checks .Valid to determine association. If you intend to represent SQL NULL here, use nil so the test matches real DB semantics.

Suggested change

"",

nil,

Copilot · 2026-02-12T12:42:11Z

sql/neutron/schema.sql

+        `device_id` varchar(255) NOT NULL,
+        `device_owner` varchar(255) NOT NULL,
+        `standard_attr_id` bigint NOT NULL,
+        `ip_allocation` varchar(16) DEFAULT NULL


The ports table definition lacks a primary key. Neutron’s ports.id is typically the primary key; missing it can break assumptions in tests/tools and can affect join correctness/deduplication when developing against this schema. Consider adding PRIMARY KEY (id) (and any other required indexes) to match the real schema more closely.

Suggested change

`ip_allocation` varchar(16) DEFAULT NULL

`ip_allocation` varchar(16) DEFAULT NULL,

PRIMARY KEY (`id`)

Copilot · 2026-02-12T12:42:11Z

go.mod

 	github.com/prometheus/procfs v0.16.1 // indirect
 	github.com/xhit/go-str2duration/v2 v2.1.0 // indirect
 	go.yaml.in/yaml/v2 v2.4.3 // indirect
+	go4.org/netipx v0.0.0-20231129151722-fdeea329fbba // indirect


go4.org/netipx is imported directly (e.g., in internal/collector/neutron/subnets.go), so it should not be marked // indirect. Running go mod tidy should correct this and keep the module metadata consistent.

Suggested change

go4.org/netipx v0.0.0-20231129151722-fdeea329fbba // indirect

go4.org/netipx v0.0.0-20231129151722-fdeea329fbba

Rosan Shanmuganathan (na50r) changed the title ~~Add more neutron metrics~~ feat: add more neutron metrics Jan 30, 2026

Rosan Shanmuganathan (na50r) force-pushed the feat/add_neutron branch 2 times, most recently from 6d70d32 to 972f94b Compare January 30, 2026 09:49

Add more neutron metrics

0c91bac

Signed-off-by: na50r <shanrosan@gmail.com>

Rosan Shanmuganathan (na50r) force-pushed the feat/add_neutron branch from 972f94b to 0c91bac Compare January 30, 2026 09:51

Rosan Shanmuganathan (na50r) added 4 commits January 30, 2026 15:31

add adjusted router tests

ef63305

Signed-off-by: na50r <shanrosan@gmail.com>

register missing descriptors

cb8bbe3

Signed-off-by: na50r <shanrosan@gmail.com>

add tests & refactor floating ip query

c49ad90

Signed-off-by: na50r <shanrosan@gmail.com>

refactor router query & add more tests

924c768

Signed-off-by: na50r <shanrosan@gmail.com>

Rosan Shanmuganathan (na50r) force-pushed the feat/add_neutron branch from 391f403 to 924c768 Compare February 2, 2026 11:09

Rosan Shanmuganathan (na50r) added 3 commits February 3, 2026 11:36

add missing metrics

689c362

Signed-off-by: na50r <shanrosan@gmail.com>

add missing metrics

9cf55c5

Signed-off-by: na50r <shanrosan@gmail.com>

add tests

60ff154

Signed-off-by: na50r <shanrosan@gmail.com>

Rosan Shanmuganathan (na50r) force-pushed the feat/add_neutron branch from 99b1b64 to 7b8e5c6 Compare February 4, 2026 13:34

fix netwrok ip availability used metrics

9e84239

Signed-off-by: na50r <shanrosan@gmail.com>

Rosan Shanmuganathan (na50r) force-pushed the feat/add_neutron branch from 7b8e5c6 to 9e84239 Compare February 4, 2026 14:25

Tadas Sutkaitis (fitbeard) requested a review from Copilot February 12, 2026 12:39

Copilot AI reviewed Feb 12, 2026

View reviewed changes

		for i, pool := range pools {
		result[i] = subnetpoolWithSubnets{&pool, subnetPrefixes[pool.ID]}

-	for i, pool := range pools {
-		result[i] = subnetpoolWithSubnets{&pool, subnetPrefixes[pool.ID]}
+	for i := range pools {
+		pool := &pools[i]
+		result[i] = subnetpoolWithSubnets{pool, subnetPrefixes[pool.ID]}

-    sp.default_prefixlen;
+    sp.default_prefixlen,
+    sp.project_id,
+    sp.name;

	`ip_allocation` varchar(16) DEFAULT NULL
	`ip_allocation` varchar(16) DEFAULT NULL,
	PRIMARY KEY (`id`)

	go4.org/netipx v0.0.0-20231129151722-fdeea329fbba // indirect
	go4.org/netipx v0.0.0-20231129151722-fdeea329fbba

Comments

Conversation

Rosan Shanmuganathan (na50r) commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tadas Sutkaitis (fitbeard) commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Rosan Shanmuganathan (na50r) Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rosan Shanmuganathan (na50r) commented Jan 30, 2026 •

edited

Loading