-
Notifications
You must be signed in to change notification settings - Fork 0
Development to master merge #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vfarafonov
wants to merge
7
commits into
master
Choose a base branch
from
development
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
da6e064
Created project
e79750a
Added buttons with no action to main activity
796b568
Update .gitignore
4617804
Merge branch 'development' of github.com:james2388/RWLab48 into devel…
1a7795b
Added buttons and actions to send intents.
f8bf0a6
Trimming
9523477
Update README.md
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,65 @@ | ||
| # Built application files | ||
| /*/build/ | ||
| app/build/ | ||
| *.apk | ||
| *.ap_ | ||
|
|
||
| # Files for the Dalvik VM | ||
| # Crashlytics configuations | ||
| com_crashlytics_export_strings.xml | ||
|
|
||
| # files for the dex VM | ||
| *.dex | ||
|
|
||
| # Java class files | ||
| *.class | ||
|
|
||
| # Generated files | ||
| # generated files | ||
| bin/ | ||
| gen/ | ||
|
|
||
| # Gradle files | ||
| .gradle/ | ||
| build/ | ||
| # Eclipse project files | ||
| .classpath | ||
| .project | ||
|
|
||
| # Local configuration file (sdk path, etc) | ||
| local.properties | ||
|
|
||
| # Proguard folder generated by Eclipse | ||
| proguard/ | ||
| # Android Studio | ||
| .gradle | ||
| build/ | ||
| /*/out | ||
| /*/*/build | ||
| /*/*/production | ||
| *.iws | ||
| *.ipr | ||
| *~ | ||
| *.swp | ||
|
|
||
| # Gradle generated files | ||
| .gradle/ | ||
|
|
||
| # Signing files | ||
| .signing/ | ||
|
|
||
| # User-specific configurations | ||
| .idea/libraries/ | ||
| .idea/workspace.xml | ||
| .idea/tasks.xml | ||
| .idea/.name | ||
| .idea/compiler.xml | ||
| .idea/copyright/profiles_settings.xml | ||
| .idea/encodings.xml | ||
| .idea/misc.xml | ||
| .idea/modules.xml | ||
| .idea/scopes/scope_settings.xml | ||
| .idea/vcs.xml | ||
| *.iml | ||
|
|
||
| # Log Files | ||
| *.log | ||
| # OS-specific files | ||
| .DS_Store | ||
| .DS_Store? | ||
| ._* | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| ehthumbs.db | ||
| Thumbs.db |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| RWLab48 | ||
| ======= | ||
|
|
||
| Lab 48 (http://redmine.ruswizards.com:8100/redmine/boards/8/topics/48) | ||
| Lab 48 (http://redmine.weezlabs.com:8100/redmine/boards/8/topics/48) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <module external.linked.project.path="$MODULE_DIR$" external.root.project.path="$MODULE_DIR$" external.system.id="GRADLE" type="JAVA_MODULE" version="4"> | ||
| <component name="FacetManager"> | ||
| <facet type="java-gradle" name="Java-Gradle"> | ||
| <configuration> | ||
| <option name="BUILD_FOLDER_PATH" value="$MODULE_DIR$/build" /> | ||
| </configuration> | ||
| </facet> | ||
| </component> | ||
| <component name="NewModuleRootManager" inherit-compiler-output="false"> | ||
| <output url="file://$MODULE_DIR$/build/classes/main" /> | ||
| <output-test url="file://$MODULE_DIR$/build/classes/test" /> | ||
| <exclude-output /> | ||
| <content url="file://$MODULE_DIR$"> | ||
| <excludeFolder url="file://$MODULE_DIR$/.gradle" /> | ||
| </content> | ||
| <orderEntry type="inheritedJdk" /> | ||
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| </component> | ||
| </module> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <module external.linked.project.path="$MODULE_DIR$" external.root.project.path="$MODULE_DIR$/.." external.system.id="GRADLE" type="JAVA_MODULE" version="4"> | ||
| <component name="FacetManager"> | ||
| <facet type="android-gradle" name="Android-Gradle"> | ||
| <configuration> | ||
| <option name="GRADLE_PROJECT_PATH" value=":app" /> | ||
| </configuration> | ||
| </facet> | ||
| <facet type="android" name="Android"> | ||
| <configuration> | ||
| <option name="SELECTED_BUILD_VARIANT" value="debug" /> | ||
| <option name="ASSEMBLE_TASK_NAME" value="assembleDebug" /> | ||
| <option name="COMPILE_JAVA_TASK_NAME" value="compileDebugSources" /> | ||
| <option name="ASSEMBLE_TEST_TASK_NAME" value="assembleDebugTest" /> | ||
| <option name="SOURCE_GEN_TASK_NAME" value="generateDebugSources" /> | ||
| <option name="TEST_SOURCE_GEN_TASK_NAME" value="generateDebugTestSources" /> | ||
| <option name="ALLOW_USER_CONFIGURATION" value="false" /> | ||
| <option name="MANIFEST_FILE_RELATIVE_PATH" value="/src/main/AndroidManifest.xml" /> | ||
| <option name="RES_FOLDER_RELATIVE_PATH" value="/src/main/res" /> | ||
| <option name="RES_FOLDERS_RELATIVE_PATH" value="file://$MODULE_DIR$/src/main/res" /> | ||
| <option name="ASSETS_FOLDER_RELATIVE_PATH" value="/src/main/assets" /> | ||
| </configuration> | ||
| </facet> | ||
| </component> | ||
| <component name="NewModuleRootManager" inherit-compiler-output="false"> | ||
| <output url="file://$MODULE_DIR$/build/intermediates/classes/debug" /> | ||
| <exclude-output /> | ||
| <content url="file://$MODULE_DIR$"> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/r/debug" isTestSource="false" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/aidl/debug" isTestSource="false" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/buildConfig/debug" isTestSource="false" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/rs/debug" isTestSource="false" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/res/rs/debug" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/res/generated/debug" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/r/test/debug" isTestSource="true" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/aidl/test/debug" isTestSource="true" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/buildConfig/test/debug" isTestSource="true" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/source/rs/test/debug" isTestSource="true" generated="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/res/rs/test/debug" type="java-test-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/build/generated/res/generated/test/debug" type="java-test-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/debug/res" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/debug/resources" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/debug/assets" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/debug/aidl" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/debug/java" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/debug/jni" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/debug/rs" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/res" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/resources" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/assets" type="java-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/aidl" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/java" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/jni" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/rs" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/androidTest/res" type="java-test-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/androidTest/resources" type="java-test-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/androidTest/assets" type="java-test-resource" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/androidTest/aidl" isTestSource="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/androidTest/java" isTestSource="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/androidTest/jni" isTestSource="true" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/androidTest/rs" isTestSource="true" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/assets" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/bundles" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/classes" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/coverage-instrumented-classes" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/dependency-cache" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/dex" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/dex-cache" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/incremental" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/jacoco" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/javaResources" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/libs" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/lint" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/manifests" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/ndk" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/pre-dexed" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/proguard" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/res" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/rs" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/intermediates/symbols" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/outputs" /> | ||
| <excludeFolder url="file://$MODULE_DIR$/build/tmp" /> | ||
| </content> | ||
| <orderEntry type="jdk" jdkName="Android API 21 Platform" jdkType="Android SDK" /> | ||
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| <orderEntry type="library" exported="" name="support-v4-21.0.2" level="project" /> | ||
| <orderEntry type="library" exported="" name="support-annotations-21.0.2" level="project" /> | ||
| <orderEntry type="library" exported="" name="appcompat-v7-21.0.2" level="project" /> | ||
| </component> | ||
| </module> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| apply plugin: 'com.android.application' | ||
|
|
||
| android { | ||
| compileSdkVersion 21 | ||
| buildToolsVersion "21.1.1" | ||
|
|
||
| defaultConfig { | ||
| applicationId "com.example.admin.rwlab48" | ||
| minSdkVersion 15 | ||
| targetSdkVersion 21 | ||
| versionCode 1 | ||
| versionName "1.0" | ||
| } | ||
| buildTypes { | ||
| release { | ||
| minifyEnabled false | ||
| proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| compile fileTree(dir: 'libs', include: ['*.jar']) | ||
| compile 'com.android.support:appcompat-v7:21.0.2' | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Add project specific ProGuard rules here. | ||
| # By default, the flags in this file are appended to flags specified | ||
| # in d:\Projects\android-sdks/tools/proguard/proguard-android.txt | ||
| # You can edit the include path and order by changing the proguardFiles | ||
| # directive in build.gradle. | ||
| # | ||
| # For more details, see | ||
| # http://developer.android.com/guide/developing/tools/proguard.html | ||
|
|
||
| # Add any project specific keep options here: | ||
|
|
||
| # If your project uses WebView with JS, uncomment the following | ||
| # and specify the fully qualified class name to the JavaScript interface | ||
| # class: | ||
| #-keepclassmembers class fqcn.of.javascript.interface.for.webview { | ||
| # public *; | ||
| #} |
13 changes: 13 additions & 0 deletions
13
app/src/androidTest/java/com/example/admin/rwlab48/ApplicationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.example.admin.rwlab48; | ||
|
|
||
| import android.app.Application; | ||
| import android.test.ApplicationTestCase; | ||
|
|
||
| /** | ||
| * <a href="http://d.android.com/tools/testing/testing_android.html">Testing Fundamentals</a> | ||
| */ | ||
| public class ApplicationTest extends ApplicationTestCase<Application> { | ||
| public ApplicationTest() { | ||
| super(Application.class); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <manifest package="com.example.admin.rwlab48" | ||
| xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
|
||
| <application | ||
| android:allowBackup="true" | ||
| android:icon="@drawable/ic_launcher" | ||
| android:label="@string/app_name" | ||
| android:theme="@style/AppTheme"> | ||
| <activity | ||
| android:name=".MainActivity" | ||
| android:label="@string/app_name"> | ||
| <intent-filter> | ||
| <action android:name="android.intent.action.MAIN"/> | ||
|
|
||
| <category android:name="android.intent.category.LAUNCHER"/> | ||
| </intent-filter> | ||
| </activity> | ||
| </application> | ||
|
|
||
| </manifest> |
92 changes: 92 additions & 0 deletions
92
app/src/main/java/com/example/admin/rwlab48/MainActivity.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /** | ||
| * Copyright (C) 2014 Rus Wizards | ||
| * | ||
| * Created: 11.12.2014 | ||
| * Vladimir Farafonov | ||
| */ | ||
| package com.example.admin.rwlab48; | ||
|
|
||
| import android.content.Intent; | ||
| import android.net.Uri; | ||
| import android.os.Bundle; | ||
| import android.provider.MediaStore; | ||
| import android.support.v7.app.ActionBarActivity; | ||
| import android.view.View; | ||
| import android.widget.Toast; | ||
|
|
||
| /** | ||
| * Main class of the app | ||
| */ | ||
| public class MainActivity extends ActionBarActivity implements View.OnClickListener { | ||
|
|
||
| private static final String LATITUDE = "37.422006"; | ||
| private static final String LONGITUDE = "-122.084095"; | ||
|
|
||
| @Override | ||
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
| setContentView(R.layout.activity_main); | ||
| } | ||
|
|
||
| @Override | ||
| public void onClick(View v) { | ||
| Intent startNextIntent; | ||
| switch (v.getId()) { | ||
| case R.id.gallery_button: | ||
| /* | ||
| * Starts gallery app. | ||
| * Have some trouble here with gallery apps on emulator (both 4.4 and 5.0). No app | ||
| * can be found and started with CATEGORY_APP_GALLERY intent. So app tries to open | ||
| * standard gallery directly with package name if no apps is found by category. | ||
| */ | ||
| startNextIntent = new Intent(Intent.ACTION_MAIN); | ||
| startNextIntent.addCategory(Intent.CATEGORY_APP_GALLERY); | ||
| if (startNextIntent.resolveActivity(getPackageManager()) == null) { | ||
| startNextIntent = getPackageManager(). | ||
| getLaunchIntentForPackage("com.android.gallery"); | ||
| } | ||
| break; | ||
| case R.id.web_browser_button: | ||
| // Puts in intent browser category | ||
| startNextIntent = new Intent(Intent.ACTION_MAIN); | ||
| startNextIntent.addCategory(Intent.CATEGORY_APP_BROWSER); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have Firefox as a default browser. This method runs Chrome instead. Need to find some workaround to launch user defined default browser. |
||
| break; | ||
| case R.id.map_button: | ||
| // Puts in intent action to view on a map app coordinates from constants | ||
| startNextIntent = new Intent(Intent.ACTION_VIEW); | ||
| startNextIntent.setData(Uri.parse("geo:" + LATITUDE + "," + LONGITUDE)); | ||
| break; | ||
| case R.id.gallery_image_button: | ||
| // Puts in intent action to get content for any type of images | ||
| startNextIntent = new Intent(Intent.ACTION_GET_CONTENT); | ||
| startNextIntent.setType("image/*"); | ||
| break; | ||
| case R.id.camera_photo_button: | ||
| // Puts in intent capture image action | ||
| startNextIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE); | ||
| break; | ||
| case R.id.camera_video_button: | ||
| // Puts in intent capture video action | ||
| startNextIntent = new Intent(MediaStore.ACTION_VIDEO_CAPTURE); | ||
| break; | ||
| case R.id.dictaphone_button: | ||
| // Puts in intent voice recording action | ||
| startNextIntent = new Intent(MediaStore.Audio.Media.RECORD_SOUND_ACTION); | ||
| break; | ||
| default: | ||
| throw new IllegalStateException( | ||
| getString(R.string.wrong_button_illegal_state_exception)); | ||
| } | ||
| if ((startNextIntent.resolveActivity(getPackageManager()) != null)) { | ||
| startNextIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); | ||
| // Start activity with apps chooser dialog (if it is more than one app) | ||
| Intent chooserIntent = Intent.createChooser( | ||
| startNextIntent, getString(R.string.title_application_chooser)); | ||
| startActivity(chooserIntent); | ||
| } else { | ||
| // Toast is shown up if apps not found | ||
| Toast.makeText(this, getString(R.string.toast_application_not_found), | ||
| Toast.LENGTH_SHORT).show(); | ||
| } | ||
| } | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indentation.