Merged
Conversation
Co-authored-by: Valient Gough <vgough@pobox.com>
Co-authored-by: Valient Gough <vgough@pobox.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: Valient Gough <vgough@pobox.com>
rfjakob
reviewed
Feb 22, 2026
| pub const DEFAULT_CONFIG_VERSION: i32 = 20260101; | ||
|
|
||
| /// Default block size for new filesystems | ||
| pub const DEFAULT_BLOCK_SIZE: i32 = 4096 - crate::crypto::block::AES_GCM_SIV_BLOCK_TAG_BYTES as i32; |
Collaborator
There was a problem hiding this comment.
Are you sure about this? It means that most writes will go through a read-modify-write cycle inside encfs.
If you use 4096, the underlying filesystem will usually do the read-modify-write.
Owner
Author
There was a problem hiding this comment.
I've applied the change just now when merging a branch.
I haven't run any benchmarks yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AES-GCM-SIV block encryption mode for V7 filesystems with per-block verification tags and an encapsulated block layer, maintaining backward compatibility.