Merged
Conversation
Three improvements: 1) write(2) errors are detected now, because writer.into_inner() flushes BufWriter's buffer 2) Errors on close(2) don't matter anymore. Before, they were not detected at all (see 3rd paragraph at https://doc.rust-lang.org/std/fs/struct.File.html ) and could cause data loss 3) File is safely on disk even if the PC crashes before the underlying filesystem decides to flush it's writeback buffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three improvements:
flushes BufWriter's buffer
detected at all (see 3rd paragraph at
https://doc.rust-lang.org/std/fs/struct.File.html ) and could
cause data loss
filesystem decides to flush it's writeback buffers