Open
Conversation
Collaborator
ryhorkisly-afk
left a comment
ryhorkisly-afk
left a comment
There was a problem hiding this comment.
you should make changes not only in the comment areas, but review the entire code
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-engine</artifactId> | ||
| <version>5.8.1</version> |
Collaborator
There was a problem hiding this comment.
write versions in properties
| } | ||
| } | ||
|
|
||
| // size() - returns the size of the list |
Collaborator
There was a problem hiding this comment.
do not use comments. turn it into javaDock
| } | ||
|
|
||
| // add(index, el) - adds the element in the list by index | ||
| public void add(int index, T value) { |
Collaborator
There was a problem hiding this comment.
it's better return somthing.
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| public class MyLinkedListTest { | ||
| // size() tests |
Collaborator
There was a problem hiding this comment.
remove comments. Better add @DisplayName annotation for every method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.