perf: Optimize app startup time by switching to PyInstaller one-folder mode#5
Merged
perf: Optimize app startup time by switching to PyInstaller one-folder mode#5
Conversation
- Change from one-file to one-folder mode in build.spec - Update Electron config to look for executable in folder structure - Update build.py to verify new folder output - Update build-electron.sh paths for one-folder mode This eliminates the ~30 second extraction delay on every app launch. PyInstaller one-file mode extracts ~80MB to temp on each start. One-folder mode keeps files ready to run immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App startup was taking ~32 seconds due to PyInstaller one-file mode extracting the entire 80MB bundle to a temp directory on every launch.
Solution
Switch from PyInstaller one-file mode to one-folder mode, which eliminates the extraction step entirely.
Changes
COLLECTblockExpected Results
Trade-offs
dist/qbox-backend/folder must be copied as a complete unitTesting
Rebuild and test with: