Conversation
… climbing record Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6b3e879 to
c755ef3
Compare
Owner
|
Rebased onto latest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #195
Adds elevation unit conversion (meters ↔ feet) following the same logic as other units: if
unit_of_lengthismile, elevation is displayed in feet. Since TeslamateAPI does not convert elevation values, the conversion is implemented inUnitFormatter.Changes
UnitFormatter
formatElevation(value: Int?, units: Units?)— formats and converts meters to feet when imperialconvertElevation(value: Float, units: Units?)— returns the numeric converted value for chart usegetElevationUnit(units: Units?)— returns"ft"or"m"for chart axis labelDriveDetailScreen
"%,d m"in elevation stats (max, min, gain, loss) withUnitFormatter.formatElevation()ElevationChartCardto useUnitFormatter.getElevationUnit()andUnitFormatter.convertElevation()viaconvertValuelambdaStatsScreen
"%,d m"in Records section (highest point, most climbing) withUnitFormatter.formatElevation()DashboardScreen
UnitFormatter.formatElevation()