Open
Conversation
65fdb07 to
86e1023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements location-based filtering in the Charges screen, as requested in #203.
Charges can now be filtered by location (address/geofence) using a dropdown placed
to the right of the AC/DC type filter chips. The filter supports multi-selection and
free-text search, and correctly updates the Summary card and bar charts alongside the
charge list.
Changes
ChargesViewModel.ktavailableLocations: List<String>andselectedLocations: Set<String>toChargesUiStatesetLocationFilter(location: String)— toggles a location in/out of the active selectionclearLocationFilter()— resets the location selectionapplyFiltersAndUpdateState()now applies the location filter to the charge list, summarycalculation and chart data so all three stay in sync
ChargesScreen.ktLocationFilterDropdowncomposable — aFilterChipthat opens aDropdownMenuwith:label when nothing is selected
ChargesContentupdated to acceptselectedLocations,onLocationFilterToggledandonLocationFilterClearedparametersChargeTypeFilterChipsupdated to accept an optionalmodifierparameter so it canparticipate in the
Rowlayout alongside the new dropdownres/values/strings.xmlfilter_locationsearchcloses #203