Skip to content

Fix: Remove blocking cleanup from video-moq disconnectedCallback #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renandincer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Remove blocking cleanup from video-moq disconnectedCallback #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/video-moq/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,14 @@ export class VideoMoq extends HTMLElement {

/**
* Called when the element is removed from the DOM
*
* Note: We intentionally skip cleanup here to avoid blocking the main thread.
* The destroy() method calls AudioContext.close() which can block for several seconds,
* causing UI freezes and test timeouts. Resources will be cleaned up by garbage collection.
* */
disconnectedCallback() {
this.destroy().catch((error) => {
console.error("Error while destroying:", error)
})
// Skip cleanup - let garbage collection handle it
// This prevents blocking issues when removing the element from DOM
}

// Called when one of the element's watched attributes change. For an attribute to be watched, you must add it to the component class's static observedAttributes property.
Expand Down