Conversation
Each loader is called twice with identical inputs. Assert both outputs exist, have different UUIDs, and matching content hashes. Refs: #131
Run fd5.schema.validate() on sealed output from raw, CSV, NIfTI, and Parquet loaders. Assert zero schema errors. Refs: #132
Wire ParquetLoader into the CLI as fd5 ingest parquet. Add parquet to _ALL_LOADER_NAMES, lazy import with clear error. Refs: #133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 3 TDD checklist gaps identified during review:
fd5.schema.validate()on sealed output from raw, CSV, NIfTI, and Parquet loadersParquetLoaderintofd5 ingest parquetCLI command with lazy import and clear error messagingCloses #131, #132, #133
Made with Cursor