feat(create): add write_dataset() and complete _HashTrackingGroup proxy#177
Merged
feat(create): add write_dataset() and complete _HashTrackingGroup proxy#177
Conversation
Add a write_dataset() convenience method on Fd5Builder so users can write individual datasets with inline hashing without going through a ProductSchema. Complete the _HashTrackingGroup proxy with __setitem__, require_group, __iter__, __len__, keys/values/items to fully mirror common h5py.Group methods. Includes integration tests for the full create-verify-validate roundtrip, write_dataset with flat/nested/existing-group paths, and all new proxy methods. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_dataset()convenience method onFd5Builderfor writing individual datasets with inline hash tracking, without going through aProductSchema_HashTrackingGroupproxy with__setitem__,require_group,__iter__,__len__,keys(),values(),items()to fully mirror commonh5py.Groupmethodswrite_dataset(flat, nested, existing-group paths), and all new proxy methodsTest plan
uv run pytest tests/test_create.py -x-- 48 tests passuv run pytest tests/ -x-- full suite 1243 tests pass🤖 Generated with Claude Code