Conversation
…xact ref - Resolve each floating tag via the exact "Get a reference" API (GET repos/.../git/ref/tags/$TAG) so the SHA is for the exact tag. - Run floating-tag updates in a dedicated job (update-floating-tags) that runs only after the release job succeeds. The main rollback job no longer captures or restores floating tags. - CHANGELOG: add Fixed entry for #38 Refs: #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes release workflow errors when updating floating tags (vX, vX.Y): moves floating-tag updates to a separate job, resolves tags via the exact "Get a reference" API to avoid wrong SHA from prefix matches, and keeps rollback self-contained. Also fixes immutable release upload failures by generating and attaching
checksums-sha256.txtduringgh release create.Type of Change
fix-- Bug fixfeat-- New featuredocs-- Documentation onlychore-- Maintenance task (deps, config, etc.)refactor-- Code restructuring (no behavior change)test-- Adding or updating testsci-- CI/CD pipeline changesbuild-- Build system or dependency changesrevert-- Reverts a previous commitstyle-- Code style (formatting, whitespace)Modifiers
!) -- This change breaks backward compatibilityChanges Made
GET /repos/{owner}/{repo}/git/ref/tags/{tag}instead of matching-refs to avoid wrong SHA from prefix matches. New job captures current SHAs, updates tags, and on failure restores from captured SHAs (self-contained).checksums-sha256.txtbefore creating the GitHub release and attach it duringgh release createinstead of uploading afterward.Changelog Entry
Testing
npm test)Manual Testing Details
Release workflow changes validated via CI and release dry-run / integration test flows.
Checklist
CHANGELOG.mdin the[Unreleased]section (and pasted the entry above)Additional Notes
Floating-tag update logic is isolated in a dedicated job so that release creation and asset uploads complete first; tag updates and their rollback are independent of the main release rollback.
Refs: #38