Min and max zoom level options for markers#5
Open
gsterndale wants to merge 2 commits intovigetlabs:masterfrom
Open
Min and max zoom level options for markers#5gsterndale wants to merge 2 commits intovigetlabs:masterfrom
gsterndale wants to merge 2 commits intovigetlabs:masterfrom
Conversation
Contributor
|
Can you show me an example page of the problem you're seeing? |
Contributor
Author
|
Hi Brian! I just rebased these commits on top of recent (related) upstream work. If you look at one of these example pages and zoom way out, the markers disappear. I found that if the map is loaded at a zoom level outside the normal visible range, the markers appear initially, but after zooming in then back out, they'd disappear. My commits should allow developers to define what zoom level range they prefer for their markers. Let me know what you think. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I found some odd marker behavior when they were created outside the MarkerManger's maxZoom.
This commit provides settings options for min and max marker zoom levels with reasonable defaults.
I'm not too familiar with Smoke and couldn't find a way to set an expectation that the MarkerManager constructor is called with the maxZoom option. Perhaps you know how???
Thanks for all the hard work!
Greg