Feature/configurable text recurrence#51
Open
CCorrado wants to merge 7 commits intovikramkakkar:masterfrom
Open
Feature/configurable text recurrence#51CCorrado wants to merge 7 commits intovikramkakkar:masterfrom
CCorrado wants to merge 7 commits intovikramkakkar:masterfrom
Conversation
…efine text labels for recurrence
… the Sublime Recurrence Picker.
Author
|
This is what this PR allows the user to do, exposing a method to add these labels to SublimeOptions when creating the picker.
|
Author
|
I was actually able to do this without the modification to the library by doing the same thing, essentially... (find the view by id off sublimePicker, pass in custom strings, etc) but it'll be a bit cleaner this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature enhancement, Allow the user to pass in some custom strings to update the text labels on the recurrence picker. Also changed the getDrawable deprecated method to ContextCompat.getDrawable().