Skip to content

Code quality fix - Exception classes should be immutable. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisal-hameed wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Code quality fix - Exception classes should be immutable. #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion library/src/main/java/com/vincestyling/netroid/AuthFailureError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ public class AuthFailureError extends NetroidError {
/**
* An intent that can be used to resolve this exception. (Brings up the password dialog.)
*/
private Intent mResolutionIntent;
private final Intent mResolutionIntent;

public AuthFailureError() {
mResolutionIntent = null;
}

public AuthFailureError(Intent intent) {
Expand All @@ -35,14 +36,17 @@ public AuthFailureError(Intent intent) {

public AuthFailureError(NetworkResponse response) {
super(response);
mResolutionIntent = null;
}

public AuthFailureError(String message) {
super(message);
mResolutionIntent = null;
}

public AuthFailureError(String message, Exception reason) {
super(message, reason);
mResolutionIntent = null;
}

public Intent getResolutionIntent() {
Expand Down