fix: remove legacy mentions of deleted classes#596
Open
tristanmsct wants to merge 1 commit intovinceliuice:masterfrom
Open
fix: remove legacy mentions of deleted classes#596tristanmsct wants to merge 1 commit intovinceliuice:masterfrom
tristanmsct wants to merge 1 commit intovinceliuice:masterfrom
Conversation
Removes all mentions of .sidebar-label and .sidebar-icon
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gnome 50 seem to have removed two classes .sidebar-label and .sidebar-icon which breaks the sidebar.
Removing mentions of those classes is an easy fix for the sidebar although I am not 100% that it will fix every issues of this nature.
This should fix those issues :