Converted disk serializers to have direct access to streams#45
Open
blazeroni wants to merge 1 commit intovincentbrison:masterfrom
Open
Converted disk serializers to have direct access to streams#45blazeroni wants to merge 1 commit intovincentbrison:masterfrom
blazeroni wants to merge 1 commit intovincentbrison:masterfrom
Conversation
Owner
|
Thanks for the PR. This could be a great feature. I will look into it and
we could discuss about it.
Le 3 mai 2017 9:36 AM, "blazeroni" <notifications@github.com> a écrit :
… This PR is a sample of what we did for #44
<#44>. Since this has
breaking changes, this isn't something that could be merged in, but it
might be helpful for a full implementation.
The important changes are in DiskCacheSerializer and DualCache. Pretty
much everything else is just test updates.
------------------------------
You can view, comment on, or merge this pull request online at:
#45
Commit Summary
- Converted disk serializers to have direct access to streams
File Changes
- *M* dualcache-demoapp/src/main/java/com/vincentbrison/
openlibraries/android/dualcache/DemoActivity.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-0> (3)
- *A* dualcache-jsonserializer/src/main/java/com/vincentbrison/
openlibraries/android/dualcache/JsonDiskSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-1> (52)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/DualCacheTest.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-2> (54)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/TestIssue11.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-3> (7)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
NoRamDiskCustomSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-4> (2)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
NoRamDiskDefaultSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-5> (2)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
RamCustomSerializerDiskCustomSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-6> (2)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
RamCustomSerializerDiskDefaultSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-7> (2)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
RamDefaultSerializerDiskCustomSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-8> (2)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
RamDefaultSerializerDiskDefaultSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-9> (2)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
RamReferenceDiskCustomSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-10> (2)
- *M* dualcache-library/src/androidTest/java/com/
vincentbrison/openlibraries/android/dualcache/lib/configurationsToTest/
RamReferenceDiskDefaultSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-11> (2)
- *M* dualcache-library/src/main/java/com/vincentbrison/
openlibraries/android/dualcache/Builder.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-12> (6)
- *M* dualcache-library/src/main/java/com/vincentbrison/
openlibraries/android/dualcache/DualCache.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-13>
(39)
- *A* dualcache-library/src/main/java/com/vincentbrison/
openlibraries/android/dualcache/IOUtil.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-14>
(22)
- *A* dualcache-serializerinterface/src/main/java/com/
vincentbrison/openlibraries/android/dualcache/DiskCacheSerializer.java
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-15>
(27)
- *M* maven_push.gradle
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-16>
(16)
- *M* maven_push_java.gradle
<https://github.com/vincentbrison/dualcache/pull/45/files#diff-17>
(16)
Patch Links:
- https://github.com/vincentbrison/dualcache/pull/45.patch
- https://github.com/vincentbrison/dualcache/pull/45.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#45>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVyYxpv__c2aY4OtMISCyyaY06rZCm1ks5r2C5zgaJpZM4NPDCG>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a sample of what we did for #44. Since this has breaking changes, this isn't something that could be merged in, but it might be helpful for a full implementation.
The important changes are in DiskCacheSerializer and DualCache. Pretty much everything else is just test updates.