[improve][admin,broker] Add option to unloadNamespaceBundle with bundle Affinity broker url#6
Open
vineeth1995 wants to merge 22 commits intomasterfrom
Open
[improve][admin,broker] Add option to unloadNamespaceBundle with bundle Affinity broker url#6vineeth1995 wants to merge 22 commits intomasterfrom
vineeth1995 wants to merge 22 commits intomasterfrom
Conversation
* add go-client chunking doc * Update site2/docs/client-libraries-go.md Co-authored-by: Zixuan Liu <nodeces@gmail.com> * Update site2/docs/client-libraries-go.md Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com> * Update site2/docs/client-libraries-go.md Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com> * Update site2/docs/client-libraries-go.md Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com> Co-authored-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
…multiple providers (apache#18035) * Update security-athenz.md * improve auth overview * address review comments * Improve OAuth2 authentication * improve Kerberos authentication * Update security-athenz.md
…he#18188) * [improve][doc] cherry-pick cpp client docs installation section Signed-off-by: tison <wander4096@gmail.com> * Apply suggestions from code review Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update client-libraries-cpp.md Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
apache#18219) ### Motivation https://github.com/apache/pulsar/blob/b061c6ac5833c21e483368febebd0d30679a35e1/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java#L748-L774 The `pendingLookupRequestSemaphore` will leak when handleError. There are `LookUpRequestSemaphore` not released when removing it from `pendingRequests` related PR: apache#17856 ### Modifications We can't easily release the semaphore in `handleError`, because there are not only `LookUpRequest`. So release the semaphore when LookupException ### Verifying this change Add unit test case to cover this change ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` bug fixs, no need doc - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
…ndle Affinity broker url
…ndle Affinity broker url
…ndle Affinity broker url
…ndle Affinity broker url
…ndle Affinity broker url
…ndle Affinity broker url
…ndle Affinity broker url
vineeth1995
force-pushed
the
bundleNamespaceAffinity
branch
from
50badf9 to
396be61
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To provide an option for admin to unload namespace bundle with broker url to which the bundle has to be assigned to after the unload.
Modifications
Add an option to provide brokerWebServiceAddress (Ex: https://broker1.com:4443) while unloadingNamespaceBundle in the admin CLI and make corresponding changes in the pulsar-client-admin-api to support this.
Changes in pulsar-broker unloadNamespaceBundle API to accommodate broker url while unloading.
Add functionality in LoadManger implementation to select affinity broker for a bundle while trying to assign unloaded bundle to broker.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: