Support webhooks#6
Open
hotdang-ca wants to merge 12 commits intovinitshahdeo:masterfrom
Open
Conversation
Owner
|
@hotdang-ca That's awesome. I'll review and merge it soon. |
vinitshahdeo
added
good first issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for GitHub Webhook.
The README has the details, but in a nutshell:
expressserver. Setup Github. Listen for webhooks.socket.ioclientsAdded socket.io to the server (server/index.js), and individually on the client (index.html).
The server should run on a publically-accessible host such as Heroku or locally on your machine in combination with Ngrok (which sets up reverse port forwarding so that you have a publically-accessible web server running on your machine, with no additional router setup required).
Tested and works... but... a little confused about the existing timer interval. Currently, one the first webhook broadcast, a notification is shown, and stays... the second webhook notification makes that notification disappear, and will not reappear until the third webhook notification is broadcast.
Depending on what type of data you want to listen to, we could just generated a new notification based on incoming payload data; but that requires a bit more collaboration on a specific set of notifications to show.