-
Notifications
You must be signed in to change notification settings - Fork 3
SQLDocument #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simukka
wants to merge
40
commits into
main
Choose a base branch
from
sqldocument
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SQLDocument #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etermine the driver type. Allow for future expansion/testing with other drivers. Preparring to write sqlcode migration for Postgres.
…upport postgresql.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLDocument provides an interface for handling SQL files.
This allows us to abstracts the logic for specific SQL languages.
Currently, this is mostly a refactor of the current logic for handling T-SQL files. But allows us to easily introduce support for pgsql languages.
The intent with this PR is to first cleanup and organize how we implement SQL language specific token parsing and handling without changing or breaking any current features or uses of sqlcode.
The goal is for us to easily introduce new SQL languages, such as Postgresql (next pr)
Other improvements:
Related PRs
API changes:
(new)
CodePatch(dbc *sql.DB, sql string)is similar toPatch, but requires a Database instance to correctly patch the provided SQL text for the current SQL driver. https://github.com/vippsas/sqlcode/pull/66/files#diff-abfd003352914455b11a902e7b7ca94b0672651ae390d52235cf282090483b53R256