Fix Monolog v3 compatibility for Magento 2.4.8#208
Open
rk-2083 wants to merge 1 commit intovippsas:masterfrom
Open
Fix Monolog v3 compatibility for Magento 2.4.8#208rk-2083 wants to merge 1 commit intovippsas:masterfrom
rk-2083 wants to merge 1 commit intovippsas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
bin/magento setup:upgradeon Magento 2.4.8 throws a fatal PHP error:Monolog v3 (shipped with Magento 2.4.8) changed the
isHandling()signaturefrom
array $recordtoMonolog\LogRecord $record, making the module completelyunusable — even
bin/magento module:disablefails.Fix
Updated
isHandling()parameter type inModel/Logger/Handler/Debug.phpto accept
\Monolog\LogRecord|array $record, compatible with both Monolog v2 and v3.Tested on
Magento 2.4.8-p4 with Monolog v3