Lots of changes for Redis & MySQL #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshadptl
changed the title
Owner
There was a problem hiding this comment.
Hey @harshadptl,
Thank you for this pull-request.
I had couple of concerns and wanted to know your opinions.
- Do we need Sismembers?. Just like Sadd, we can use Sismember to work with multiple keys IMO.
- Instead of returning NoImplemented error, wouldnt it be useful if we could use "get" or any other workaround to check membership?.
Author
There was a problem hiding this comment.
- Thats a good idea
- Didn't get your point
Owner
There was a problem hiding this comment.
For 2. Instead of returning this "errors.New("mantle: SETS/Sismember unimplemented for memcache datastore")", we can do a get(key) and check if it exists. NotImpleted error is not so useful IMO.
This reverts commit 6d9ce85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.