Draft
Conversation
Closed
sameo
approved these changes
Mar 26, 2023
Contributor
sameo
left a comment
There was a problem hiding this comment.
LGTM aside from a typo. FWIW this is a draft PR, I can't merge it.
Contributor
Author
|
The work in this PR will soon be replaced by the work on a memory "allocator", it will handle both the EBDA memory region and the BIOS/APIC/MSI interrupts gaps. |
This commits adds support for allocating memory over 4GiB to the VM. It creates a new memory region after the APIC and MSI interrupt region. Signed-off-by: Nils Ponsard <nilsponsard@gmail.com>
61ee97e to
f8f9ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the PR about the MMIO gap.
This commits adds support for allocating memory over 4GiB to the VM. It creates a new memory region after the APIC and MSI interrupt region.
Fixes #34