Open
Conversation
jlabatut
force-pushed
the
3-quark-builder
branch
from
d1d29ae to
eff68b9
Compare
Contributor
|
Still a draft @jlabatut ? |
Author
|
Yes, it should be ready to review in a couple of days.
|
Author
|
Hi @sameo, PR ready for review ! |
jlabatut
changed the title
build subcommandquark builder
sameo
reviewed
Apr 28, 2022
src/cli/build.rs
Outdated
| #[clap(short, long)] | ||
| image: String, | ||
|
|
||
| /// Indicates wether or not the container image is bundled into the initramfs image |
Contributor
There was a problem hiding this comment.
What happens if it's not. Where will the image come from?
Author
There was a problem hiding this comment.
This should be the role of Kaps to pull the image from the name / URL stated in the build command (and in the quark.json file).
- fetches `kaps` from GitHub (https://github.com/virt-do/kaps), builds it with `cargo`. - clones Cloud Hypervisor repository (https://github.com/cloud-hypervisor/linux), builds a Linux kernel using a specific configuration (https://github.com/virt-do/lumper/blob/main/kernel/linux-config-x86_64). - if offline mode is selected, fetches a `.tar.gz` archive from an URL an builds a container bundle containing the rootfs of the container and a `runc` config file. - creates an initrootfs image (`lzma` format) from an `alpine` image, containing the container bundle, the `kaps` binary and an init file to launch `kaps` using the bundle. - wraps the kernel, the initrootfs image and a `quark.json` config file inside a `quardle`. Signed-off-by: Julian Labatut <julian.labatut@etu.umontpellier.fr>
Author
|
Hi @sameo, PR is ready again for a review. Thanks. |
Author
|
This PR should be merged before #6 (@MaloPolese) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3