aws: fix f-string error when print log#697
Merged
liangxiao1 merged 1 commit intovirt-s1:masterfrom Mar 24, 2026
Merged
Conversation
python11 f-string does not accept double quotation, update to single.
Traceback (most recent call last):
File "/home/ec2/p3_venv/bin/os-tests", line 8, in <module>
sys.exit(main())
^^^^^^
File "/home/ec2/p3_venv/lib64/python3.11/site-packages/os_tests/os_tests_run.py", line 38, in main
vms, disks, nics, nets = init_provider(params=params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ec2/p3_venv/lib64/python3.11/site-packages/os_tests/libs/utils_lib.py", line 157, in init_provider
from .resources_aws import EC2VM,EC2Volume,EC2NIC
File "/home/ec2/p3_venv/lib64/python3.11/site-packages/os_tests/libs/resources_aws.py", line 98
LOG.info(f"Use exists {self.id} which is_allow_delete is {self.params.get("is_allow_delete")}")
^^^^^^^^^^^^^^^
SyntaxError: f-string: unmatched '('
Signed-off-by: Frank Liang <xiliang@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFixes a Python 3.11 f-string syntax error in AWS EC2 resource logging by switching the inner string quotes from double to single quotes inside the f-string expressions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The same logging message is now duplicated in both
createanddelete; consider extracting this into a small helper method or shared constant to avoid repetition and keep future changes to the message in one place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The same logging message is now duplicated in both `create` and `delete`; consider extracting this into a small helper method or shared constant to avoid repetition and keep future changes to the message in one place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python11 f-string does not accept double quotation, update to single. Traceback (most recent call last):
File "/home/ec2/p3_venv/bin/os-tests", line 8, in
sys.exit(main())
^^^^^^
File "/home/ec2/p3_venv/lib64/python3.11/site-packages/os_tests/os_tests_run.py", line 38, in main
vms, disks, nics, nets = init_provider(params=params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ec2/p3_venv/lib64/python3.11/site-packages/os_tests/libs/utils_lib.py", line 157, in init_provider
from .resources_aws import EC2VM,EC2Volume,EC2NIC
File "/home/ec2/p3_venv/lib64/python3.11/site-packages/os_tests/libs/resources_aws.py", line 98
LOG.info(f"Use exists {self.id} which is_allow_delete is {self.params.get("is_allow_delete")}")
^^^^^^^^^^^^^^^
SyntaxError: f-string: unmatched '('
Summary by Sourcery
Bug Fixes: