Skip to content

Increase memory for cnv vm provision.#699

Merged
libhe merged 1 commit intovirt-s1:masterfrom
libhe:master
Mar 26, 2026
Merged

Increase memory for cnv vm provision.#699
libhe merged 1 commit intovirt-s1:masterfrom
libhe:master

Conversation

@libhe
Copy link
Copy Markdown
Collaborator

@libhe libhe commented Mar 26, 2026

Summary by Sourcery

Enhancements:

  • Raise the configured memory for the small VM flavor from 2 to 4Gi in the OpenShift test configuration.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Mar 26, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the OpenShift VM flavor configuration to allocate more memory and normalize empty YAML fields formatting for CNV VM provisioning tests.

File-Level Changes

Change Details Files
Increase VM memory allocation in OpenShift flavor configuration for CNV VM provisioning.
  • Change Flavor.memory value from a plain number to a Gi-suffixed quantity (2 → 4Gi) to double the VM memory and comply with expected Kubernetes-style quantity format.
  • Normalize YAML formatting by removing trailing spaces on empty scalar fields (apiserver, password, image_name).
os_tests/cfg/openshift.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The memory field changed from a bare integer (2) to a quantity with units (4Gi); double-check this matches the expected schema/consumer logic for Flavor.memory, which may still expect a numeric value rather than a string with units.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `memory` field changed from a bare integer (`2`) to a quantity with units (`4Gi`); double-check this matches the expected schema/consumer logic for `Flavor.memory`, which may still expect a numeric value rather than a string with units.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@libhe libhe merged commit 8e2076f into virt-s1:master Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant